-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove FileReader #2728
base: next
Are you sure you want to change the base?
remove FileReader #2728
Conversation
When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore! |
Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year. |
Of course not 😅. I was just talking about way in the future. We still have our own File. |
Rebase to next branch? |
28d81d2
to
fefe90d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2728 +/- ##
=======================================
Coverage ? 88.44%
=======================================
Files ? 81
Lines ? 7384
Branches ? 0
=======================================
Hits ? 6531
Misses ? 853
Partials ? 0 ☔ View full report in Codecov by Sentry. |
can we land this? 👀 |
I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. web-platform-tests/wpt#44893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess this can land in next? What is blocking this? |
Now that we've removed our File impl. we can stop running the fileapi WPTs altogether. |
No description provided.